Hotfix update that includes some minor bug fixes and improvements in docs #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devanshjainms
requested review from
Copilot,
dennispadia,
dhruvmicrosoft and
hdamecharla
and removed request for
dhruvmicrosoft
There was a problem hiding this comment.
Copilot reviewed 33 out of 34 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- requirements.in: Language not supported
Comments suppressed due to low confidence (2)
src/roles/ha_db_hana/tasks/secondary-node-kill.yml:101
- Ensure that replacing the specialized post validations task file with the common 'post-validations.yml' file handles all validation scenarios correctly, as this change affects error handling and task flow.
ansible.builtin.include_tasks: "roles/misc/tasks/post-validations.yml"
src/modules/filesystem_freeze.py:108
- The updated logic to check for both '/hana/shared' and '/hana/shared/{self.database_sid}' assumes these are the only valid mount points. Confirm that this condition covers all intended filesystem configurations.
if len(parts) > 1 and parts[1] in [
… cluster service boot settings
…lity improvements
devanshjainms
added a commit
to devanshjainms/sap-automation-qa
that referenced
this pull request
Apr 14, 2025
devanshjainms
added
bug
devanshjainms
added a commit
that referenced
this pull request
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the SAP Testing Automation Framework documentation, codebase, and dependencies. The changes improve documentation clarity, update dependencies, and enhance functionality in specific modules and tasks.
Documentation updates:
README.md: Added images and a badge for GitHub issues to improve the visual appeal and provide quick access to issue tracking.docs/HIGH_AVAILABILITY.md: Updated instructions to fork the repository before cloning and added a new section on updating the framework to keep forks up to date with the latest changes. [1] [2]Dependency updates:
requirements.in: Added various packages for Ansible, Azure, development tools, testing, data processing, core utilities, and CLI tools to ensure all necessary dependencies are included.Code enhancements:
src/modules/filesystem_freeze.py: Added a new parameterdatabase_sidto theFileSystemFreezeclass and updated the_find_filesystemmethod to account for the database SID when finding the filesystem. [1] [2] [3]src/modules/get_pcmk_properties_db.pyandsrc/modules/get_pcmk_properties_scs.py: Modified the_parse_resourcemethod to strip trailing 's' from timeout and interval values to ensure consistency. [1] [2]Task adjustments:
src/roles/ha_db_hana/tasks/block-network.yml: Consolidated node connectivity checks and updated post-validation task includes to use a common file. [1] [2] [3]src/roles/ha_db_hana/tasks/fs-freeze.yml,src/roles/ha_db_hana/tasks/primary-crash-index.yml,src/roles/ha_db_hana/tasks/primary-echo-b.yml: Updated post-validation task includes to use a common file. [1] [2] [3] [4] [5] [6] [7]Configuration updates:
src/roles/ha_db_hana/tasks/files/constants.yaml: Removed trailing 's' from interval and timeout values in resource defaults to ensure consistency. [1] [2] [3]